Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v1.32.0 #6603

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Sep 14, 2021

No description provided.

@nkubala nkubala requested a review from a team as a code owner September 14, 2021 20:30
@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #6603 (8dc6c07) into main (290280e) will decrease coverage by 0.66%.
The diff coverage is 34.27%.

❗ Current head 8dc6c07 differs from pull request most recent head 9b3ef72. Consider uploading reports for the commit 9b3ef72 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6603      +/-   ##
==========================================
- Coverage   70.48%   69.82%   -0.67%     
==========================================
  Files         515      520       +5     
  Lines       23150    23594     +444     
==========================================
+ Hits        16317    16474     +157     
- Misses       5776     6055     +279     
- Partials     1057     1065       +8     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 89.00% <0.00%> (-1.82%) ⬇️
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/debug/apply_transforms.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/debug/transform.go 95.91% <ø> (ø)
.../skaffold/deploy/component/kubernetes/component.go 90.00% <0.00%> (-4.74%) ⬇️
pkg/skaffold/deploy/docker/deploy.go 0.00% <0.00%> (ø)
pkg/skaffold/docker/client.go 90.36% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1186c42...9b3ef72. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit to fix

@@ -17,7 +17,7 @@ test:
- <paths glob>
```

As tests take time, you might prefer to configure tests using [profiles](https://skaffold.dev/docs/environment/profiles/) so that they can be automatically enabled or disabled, e.g.
As tests take time, you might prefer to configure tests using [profiles](https://skaffold.dev/docs/https://skaffold.dev/docs/environment/profiles/) so that they can be automatically enabled or disabled, e.g.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't look right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it sure doesn't, this was autogenerated by our release script...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this slipped through in #5451, but i'm really not sure how it's just getting synced now. fixed anyway

@nkubala nkubala merged commit edd1d45 into GoogleContainerTools:main Sep 15, 2021
@nkubala nkubala deleted the release/v1.32.0 branch September 15, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants