Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add inventory flags for skaffold apply #6406

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Aug 10, 2021

cloud deploy requested feature.

Related: #5673

@yuwenma yuwenma requested review from tejal29 and nkubala August 10, 2021 22:59
@yuwenma yuwenma requested a review from a team as a code owner August 10, 2021 22:59
@google-cla google-cla bot added the cla: yes label Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #6406 (fc2b475) into v2 (b560b5e) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #6406      +/-   ##
==========================================
- Coverage   69.88%   69.86%   -0.02%     
==========================================
  Files         479      479              
  Lines       22019    22033      +14     
==========================================
+ Hits        15388    15394       +6     
- Misses       5606     5610       +4     
- Partials     1025     1029       +4     
Impacted Files Coverage Δ
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/deploy/v2/kpt/kpt.go 52.72% <14.28%> (-1.99%) ⬇️
cmd/skaffold/app/cmd/apply.go 41.66% <100.00%> (+16.66%) ⬆️
pkg/skaffold/runner/deployer.go 64.51% <100.00%> (ø)
pkg/skaffold/util/tar.go 52.87% <0.00%> (-4.60%) ⬇️
pkg/skaffold/docker/parse.go 88.23% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b560b5e...fc2b475. Read the comment docs.

@yuwenma yuwenma merged commit bff7f8f into GoogleContainerTools:v2 Aug 10, 2021
@yuwenma yuwenma deleted the v2-17-cloud-deploy branch August 10, 2021 23:24
yuwenma added a commit to yuwenma/skaffold that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants