Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] enable skaffold delete in kpt v2 deployer & backport ContainerHook #6388

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[v2] enable skaffold delete in kpt v2 deployer & backport ContainerHook #6388

merged 1 commit into from
Aug 10, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Aug 9, 2021

Related: #5673

@yuwenma yuwenma requested a review from tejal29 August 9, 2021 15:38
@yuwenma yuwenma requested a review from a team as a code owner August 9, 2021 15:38
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #6388 (2dfbb7b) into v2 (8544d9a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #6388      +/-   ##
==========================================
- Coverage   69.91%   69.91%   -0.01%     
==========================================
  Files         479      479              
  Lines       22008    22010       +2     
==========================================
+ Hits        15387    15388       +1     
- Misses       5599     5600       +1     
  Partials     1022     1022
Impacted Files Coverage Δ
pkg/skaffold/deploy/v2/kpt/kpt.go 56.66% <0.00%> (-0.77%) ⬇️
pkg/skaffold/schema/latest/v1/config.go 24.32% <ø> (ø)
pkg/skaffold/schema/v2beta19/config.go 24.32% <ø> (ø)
pkg/skaffold/schema/v2beta20/config.go 24.32% <ø> (ø)
pkg/skaffold/docker/image.go 80.08% <0.00%> (-1.22%) ⬇️
pkg/skaffold/util/tar.go 57.47% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8544d9a...2dfbb7b. Read the comment docs.

@yuwenma yuwenma force-pushed the v2-15-delete branch 2 times, most recently from f5f9364 to 5501ed2 Compare August 9, 2021 18:13
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 9, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 10, 2021
@yuwenma yuwenma mentioned this pull request Aug 10, 2021
Merged
@yuwenma yuwenma changed the title [v2] enable skaffold delete in kpt v2 deployer [v2] enable skaffold delete in kpt v2 deployer & backport ContainerHook Aug 10, 2021
@yuwenma yuwenma merged commit 67b9f28 into GoogleContainerTools:v2 Aug 10, 2021
@yuwenma yuwenma deleted the v2-15-delete branch August 10, 2021 19:26
yuwenma added a commit to yuwenma/skaffold that referenced this pull request Nov 8, 2021
@yuwenma
[v2] enable skaffold delete in kpt v2 deployer & backport Container…
3e2d252 
…Hook (GoogleContainerTools#6388)

Basic backport changes. PR has been waited for a while.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuwenma