Replace gometalinter with GolangCI-Lint #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
reviewed
May 31, 2018
| @@ -91,8 +91,7 @@ func (a *LogAggregator) Start(ctx context.Context, client corev1.CoreV1Interface | |||
| return nil | |||
| } | |||
|
|
|||
| // nolint: interfacer | |||
| func (a *LogAggregator) streamLogs(ctx context.Context, client corev1.CoreV1Interface, pod *v1.Pod) error { | |||
| func (a *LogAggregator) streamLogs(ctx context.Context, client corev1.PodsGetter, pod *v1.Pod) error { | |||
There was a problem hiding this comment.
Having this as a corev1interface instead of podsgetter was intentional, even though it failed linting.
Switching it gave me an error downstream. I don't think it would be covered by tests. I'll have to test it again.
There was a problem hiding this comment.
What do you mean downstream? e2e tests?
There was a problem hiding this comment.
Yep - i think the error I was thinking of was actually in wait.go where I had the nolint: interfacer. This LGTM
dgageot
force-pushed
the
golangci-lint
branch
2 times, most recently
from
615e025 to
92f15d3
Compare
Running test.sh is down from 34s to 20s on my machine. Also, from now on, run go lint. Signed-off-by: David Gageot <david@gageot.net>
r2d4
approved these changes
Jun 4, 2018
| @@ -91,8 +91,7 @@ func (a *LogAggregator) Start(ctx context.Context, client corev1.CoreV1Interface | |||
| return nil | |||
| } | |||
|
|
|||
| // nolint: interfacer | |||
| func (a *LogAggregator) streamLogs(ctx context.Context, client corev1.CoreV1Interface, pod *v1.Pod) error { | |||
| func (a *LogAggregator) streamLogs(ctx context.Context, client corev1.PodsGetter, pod *v1.Pod) error { | |||
There was a problem hiding this comment.
Yep - i think the error I was thinking of was actually in wait.go where I had the nolint: interfacer. This LGTM
r2d4
previously requested changes
Jun 4, 2018
|
Signed-off-by: David Gageot <david@gageot.net>
|
@r2d4 I rebased and fixed the new errors. Let's merge! |
priyawadhwa
pushed a commit
to priyawadhwa/kaniko
that referenced
this pull request
Sep 11, 2018
gometalinter is broken @ HEAD, and I looked into why that was. During that process, I remembered that we took the linting scripts from skaffold, and found that in skaffold gometalinter was replaced with GolangCI-Lint: GoogleContainerTools/skaffold#619 The change made linting in skaffold faster, so I figured instead of fixing gometalinter it made more sense to remove it and replace it with GolangCI-Lint for kaniko as well.
priyawadhwa
pushed a commit
to priyawadhwa/kaniko
that referenced
this pull request
Sep 11, 2018
gometalinter is broken @ HEAD, and I looked into why that was. During that process, I remembered that we took the linting scripts from skaffold, and found that in skaffold gometalinter was replaced with GolangCI-Lint: GoogleContainerTools/skaffold#619 The change made linting in skaffold faster, so I figured instead of fixing gometalinter it made more sense to remove it and replace it with GolangCI-Lint for kaniko as well.
priyawadhwa
pushed a commit
to priyawadhwa/kaniko
that referenced
this pull request
Sep 11, 2018
gometalinter is broken @ HEAD, and I looked into why that was. During that process, I remembered that we took the linting scripts from skaffold, and found that in skaffold gometalinter was replaced with GolangCI-Lint: GoogleContainerTools/skaffold#619 The change made linting in skaffold faster, so I figured instead of fixing gometalinter it made more sense to remove it and replace it with GolangCI-Lint for kaniko as well.
priyawadhwa
pushed a commit
to priyawadhwa/kaniko
that referenced
this pull request
Sep 11, 2018
gometalinter is broken @ HEAD, and I looked into why that was. During that process, I remembered that we took the linting scripts from skaffold, and found that in skaffold gometalinter was replaced with GolangCI-Lint: GoogleContainerTools/skaffold#619 The change made linting in skaffold faster, so I figured instead of fixing gometalinter it made more sense to remove it and replace it with GolangCI-Lint for kaniko as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running test.sh is down from 34s to 20s on my
machine.
Also, from now on, run go lint.
Signed-off-by: David Gageot david@gageot.net