Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Major refactoring for v2 runner/runcontext #6077

Closed
wants to merge 1 commit into from
Closed

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jun 25, 2021

Related: #5673

Description

  • Seperate runcontext.Runcontext to V1 and V2, each runcontext holds its own v1 and v2 schema
  • Store schema configs in their versioned runner. This decouple the versioned functions in cmd (where latestV1 is referred).
  • Add Renderer to withTiming

@yuwenma yuwenma requested a review from a team as a code owner June 25, 2021 02:40
@yuwenma yuwenma requested a review from aaron-prindle June 25, 2021 02:40
@google-cla google-cla bot added the cla: yes label Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #6077 (c8c90dc) into master (36803b4) will decrease coverage by 0.62%.
The diff coverage is 21.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6077      +/-   ##
==========================================
- Coverage   70.20%   69.58%   -0.63%     
==========================================
  Files         475      479       +4     
  Lines       18147    18325     +178     
==========================================
+ Hits        12741    12751      +10     
- Misses       4470     4638     +168     
  Partials      936      936              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/apply.go 25.00% <0.00%> (ø)
cmd/skaffold/app/cmd/cmd.go 69.04% <ø> (+0.47%) ⬆️
cmd/skaffold/app/cmd/delete.go 57.14% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 61.90% <0.00%> (+5.38%) ⬆️
cmd/skaffold/app/cmd/filter.go 25.58% <0.00%> (ø)
cmd/skaffold/app/cmd/generate_pipeline.go 61.53% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 40.74% <0.00%> (ø)
cmd/skaffold/app/cmd/test.go 53.84% <0.00%> (+7.17%) ⬆️
pkg/skaffold/debug/apply_transforms.go 32.83% <ø> (ø)
pkg/skaffold/render/renderer/renderer.go 59.30% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36803b4...c8c90dc. Read the comment docs.

@yuwenma yuwenma removed the request for review from aaron-prindle June 25, 2021 05:48
    - Seperate runcontext.Runcontext to V1 and V2, each runcontext holds its own v1 and v2 schema
    - Store schema configs in their versioned runner. This decouple the versioned functions in cmd (where latestV1 is referred).
    - Add Renderer to withTiming
@yuwenma yuwenma changed the title [v2] Decouple the runner creation from v1 schema but using schema interface util.VersionedConfig. [v2] Major refactoring for v2 runner/runcontext Jun 25, 2021
@yuwenma yuwenma requested review from nkubala and tejal29 June 25, 2021 06:03
@yuwenma
Copy link
Contributor Author

yuwenma commented Jun 26, 2021

Moved to #6081

@yuwenma yuwenma closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants