Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add transformer in renderer step. #6051

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jun 21, 2021

Fixes: #nnn
Related: #5673

@yuwenma yuwenma requested a review from a team as a code owner June 21, 2021 21:22
@yuwenma yuwenma requested a review from tejal29 June 21, 2021 21:22
@google-cla google-cla bot added the cla: yes label Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #6051 (31c58d0) into master (d658049) will decrease coverage by 0.01%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
- Coverage   70.25%   70.24%   -0.02%     
==========================================
  Files         473      474       +1     
  Lines       18110    18165      +55     
==========================================
+ Hits        12724    12760      +36     
- Misses       4454     4472      +18     
- Partials      932      933       +1     
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/v2/config.go 100.00% <ø> (ø)
pkg/skaffold/schema/v3alpha1/config.go 50.00% <ø> (ø)
pkg/skaffold/render/renderer/renderer.go 59.30% <46.15%> (-2.86%) ⬇️
pkg/skaffold/render/transform/transform.go 60.46% <60.46%> (ø)
pkg/skaffold/render/validate/validate.go 100.00% <100.00%> (ø)
pkg/skaffold/docker/parse.go 86.19% <0.00%> (-0.96%) ⬇️
pkg/skaffold/docker/image.go 79.53% <0.00%> (+1.39%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d658049...31c58d0. Read the comment docs.

Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits

pkg/skaffold/render/transform/transform.go Outdated Show resolved Hide resolved
pkg/skaffold/render/transform/transform.go Outdated Show resolved Hide resolved
@yuwenma yuwenma force-pushed the render-5-mutator branch 3 times, most recently from 9d76be5 to e6e57d4 Compare June 23, 2021 04:26
@yuwenma yuwenma force-pushed the render-5-mutator branch from e6e57d4 to 31c58d0 Compare June 23, 2021 06:02
@tejal29 tejal29 merged commit 3a531d6 into GoogleContainerTools:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants