Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have BuildSubtaskEvent use InProgress status #5963

Merged

Conversation

MarlonGamez
Copy link
Contributor

Description
BuildSubtaskEvents were using Started status instead of InProgress. This fixes that

@MarlonGamez MarlonGamez requested a review from a team as a code owner June 7, 2021 21:19
@MarlonGamez MarlonGamez requested a review from gsquared94 June 7, 2021 21:19
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@tejal29 tejal29 enabled auto-merge (squash) June 7, 2021 21:21
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #5963 (353357d) into master (20e00dc) will increase coverage by 0.12%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5963      +/-   ##
==========================================
+ Coverage   70.57%   70.69%   +0.12%     
==========================================
  Files         457      459       +2     
  Lines       17534    17585      +51     
==========================================
+ Hits        12374    12432      +58     
+ Misses       4246     4234      -12     
- Partials      914      919       +5     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/inspect_modules.go 87.50% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 92.30% <0.00%> (ø)
pkg/skaffold/inspect/types.go 100.00% <ø> (ø)
pkg/skaffold/deploy/kpt/kpt.go 82.04% <68.08%> (+4.78%) ⬆️
cmd/skaffold/app/cmd/inspect_build_env.go 59.85% <78.78%> (+4.02%) ⬆️
pkg/skaffold/inspect/buildEnv/modify_gcb.go 81.25% <81.25%> (ø)
pkg/skaffold/inspect/errors.go 56.09% <85.18%> (+56.09%) ⬆️
pkg/skaffold/deploy/status/status_check.go 69.40% <85.71%> (-0.30%) ⬇️
cmd/skaffold/app/cmd/inspect.go 100.00% <100.00%> (ø)
pkg/skaffold/build/util.go 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0e186...353357d. Read the comment docs.

@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 7, 2021
@tejal29 tejal29 merged commit 4bd76de into GoogleContainerTools:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants