Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Add the Kptfile struct to render. #5940

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jun 4, 2021

Related: #5673

Description

There are two approaches to read Kptfile. One is via templating which we can add comments to help users understand the Kptfile. The other is via go struct which is more accurate and less error-prone. Considering the reliability of the Kpt deprecation policies (the api schema is not expected to change and if it is changed it will be backward compatible. If not backward compatible, the deprecation has a year-long period), go struct is used here.

@yuwenma yuwenma requested a review from a team as a code owner June 4, 2021 04:26
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
There are two approaches to read Kptfile. One is via templating which we can add comments to help users understand the Kptfile. The other is via go struct which is more accurate and less error-prone. Considering the reliability of the Kpt deprecation policies (the api schema is not expected to change and if it is changed it will be backward compatible. If not backward compatible, the deprecation has a year-long period)
@yuwenma yuwenma force-pushed the render-3-Kptfile branch from 820c91d to df4817a Compare June 4, 2021 04:34
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #5940 (df4817a) into master (fafdcd7) will decrease coverage by 0.09%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5940      +/-   ##
==========================================
- Coverage   70.67%   70.58%   -0.10%     
==========================================
  Files         454      455       +1     
  Lines       17395    17427      +32     
==========================================
+ Hits        12294    12300       +6     
- Misses       4195     4219      +24     
- Partials      906      908       +2     
Impacted Files Coverage Δ
pkg/skaffold/render/kptfile/pipeline_type.go 0.00% <0.00%> (ø)
pkg/skaffold/render/renderer/renderer.go 41.17% <44.44%> (-8.83%) ⬇️
pkg/skaffold/event/v2/event.go 74.03% <0.00%> (+0.12%) ⬆️
pkg/skaffold/runner/v1/dev.go 73.11% <0.00%> (+0.12%) ⬆️
...skaffold/kubernetes/debugging/container_manager.go 50.98% <0.00%> (+0.98%) ⬆️
...affold/kubernetes/portforward/forwarder_manager.go 50.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafdcd7...df4817a. Read the comment docs.

@yuwenma yuwenma added this to the v1.26.0 milestone Jun 4, 2021
@tejal29 tejal29 merged commit e15b5c9 into GoogleContainerTools:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants