[V3] Add flag as v3 entrypoint. #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
force-pushed
the
experimental-flag
branch
from
661ffbd to
4095815
Compare
yuwenma
force-pushed
the
experimental-flag
branch
from
4095815 to
9e445ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #5694 +/- ##
=======================================
Coverage 70.64% 70.64%
=======================================
Files 411 411
Lines 15858 15860 +2
=======================================
+ Hits 11203 11205 +2
Misses 3827 3827
Partials 828 828
Continue to review full report at Codecov.
|
tejal29
reviewed
Apr 20, 2021
| @@ -509,6 +509,15 @@ var flagRegistry = []Flag{ | |||
| DefinedOn: []string{"debug", "dev", "run"}, | |||
| IsEnum: true, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Can we make this flag hidden for now?
wuxingzhong
pushed a commit
to wuxingzhong/skaffold
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5673
Description
Allow users to have access to V3 (skaffold render v2) via a "--experimental" flag in
skaffold dev|render|deploy|runconmmands.This flag can be turned off once all V3 features are completed. Due to the long developing period as well as the kpt dependencies, we will support both v2 and V3 version streams developing and releasing together (A single skaffold binary) until V3 is ready for Beta.
Users can switch between V2 and V3 via the experimental flag. e.g.
skaffold dev --experimental ...uses V3.We also need a release.md doc (for developers) to talk about the new stream.
Following Changes
Schema refactoring for V3
Runner refactoring: #5692