Improve the logs #513
Merged
Improve the logs #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
trying-fixing-logs
branch
from
18a4f0c to
1121c80
Compare
dgageot
force-pushed
the
trying-fixing-logs
branch
7 times, most recently
from
bbfa266 to
4d453e6
Compare
+ First second of logs can be lost + The code tries to reconnect to pods that are known to be terminated. Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
trying-fixing-logs
branch
from
4d453e6 to
204a67a
Compare
dlorenc
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
Signed-off-by: David Gageot david@gageot.net