Support ~ in secret path for Kaniko #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
reviewed
Apr 27, 2018
|
|
||
| absPath, err := homedir.Expand(cfg.Build.KanikoBuild.PullSecret) | ||
| if err != nil { | ||
| logrus.Errorln("unable to expand pullSecret", cfg.Build.KanikoBuild.PullSecret) |
There was a problem hiding this comment.
It makes the default code a bit uglier, but ApplyProfiles returns an error so we can return a real error here instead of logrus.Errorln
|
@r2d4 I fixed the code based on your feedback! |
dgageot
force-pushed
the
kaniko-home
branch
6 times, most recently
from
e6ebd5e to
7f9f7e2
Compare
dgageot
force-pushed
the
kaniko-home
branch
4 times, most recently
from
5384c2d to
727d203
Compare
Signed-off-by: David Gageot <david@gageot.net>
tejal29
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net