-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node
wrapper to debug NodeJS apps
#4086
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if I understand correctly, /dbg/nodejs/bin
was added to the debug helper image in GoogleContainerTools/container-debug-support#34. but that image tag wasn't bumped anywhere here - where is that referenced in skaffold? i'm wondering if we integration tests that run in CI to make sure nothing in this image changes out from under our feet.
We live at |
Fixes: #2170
Description
Cause NodeJS apps to use the newly-introduced
node
wrapper.Many applications use NodeJS-based tools as part of their launch, like
npm
, rather thaninvoke
node
directly. These intermediatenode
instances may interpret the--inspect
arguments. GoogleContainerTools/container-debug-support#34 introduced anode
wrapper that only passes--inspect
when provided an application script, and otherwise propagates--inspect
via an environment variable.One other minor change: this now sorts the environment variables when populating the k8s
Container
objects to make comparisons stable in the tests.User facing changes
NodeJS apps that previously seemed undebuggable should now respond to debugging treatment.