Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better status check #3892

Merged
merged 6 commits into from
Apr 2, 2020
Merged

Better status check #3892

merged 6 commits into from
Apr 2, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 31, 2020

  • Don't print the status summary if the user ctrl-Cd …
  • Print deployment statuses with default colour …
  • Omit “default:” namespace prefix …
  • Remove duplicate name from the status …

@dgageot dgageot force-pushed the better-status-check branch from 2b6848d to dde2f53 Compare March 31, 2020 14:07
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #3892 into master will increase coverage by 0.03%.
The diff coverage is 76%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/base.go 100% <100%> (+15.38%) ⬆️
pkg/skaffold/deploy/status_check.go 68.3% <66.66%> (-0.76%) ⬇️
pkg/skaffold/deploy/resource/deployment.go 90.9% <75%> (-3.69%) ⬇️
pkg/skaffold/runner/deploy.go 67.85% <75%> (+1.19%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot dgageot force-pushed the better-status-check branch from dde2f53 to 8337c04 Compare March 31, 2020 14:52
dgageot added 6 commits April 1, 2020 11:01
@dgageot
Quick exit
c2bfb1a 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Don't print the status summary if the user ctrl-Cd
9821dda 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Omit “default:” namespace prefix
13627fc 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Print deployment statuses with default colour
fc0db3d 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Remove duplicate name from the status
f1fbd7c 
Also lowercase status

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Don't print the status summary if the user ctrl-Cd
fb269ee 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the better-status-check branch from 8337c04 to fb269ee Compare April 1, 2020 09:01
@balopat balopat self-assigned this Apr 2, 2020
@balopat balopat merged commit 15aade6 into GoogleContainerTools:master Apr 2, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
@tejal29 tejal29 mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees

@balopat balopat

Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot