Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler code dealing with durations #3709

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Simpler code dealing with durations #3709

merged 1 commit into from
Feb 20, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 20, 2020

Signed-off-by: David Gageot david@gageot.net

@dgageot
Simpler code dealing with durations
89e28cb 
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Feb 20, 2020 •
edited
Loading

Codecov Report

Merging #3709 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@tejal29 tejal29 merged commit 64852eb into GoogleContainerTools:master Feb 20, 2020
@fmotrifork fmotrifork mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @tejal29 @googlebot