Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bp] Use the same Docker client than Skaffold #3602

Merged
merged 1 commit into from
Jan 28, 2020
Merged

[bp] Use the same Docker client than Skaffold #3602

merged 1 commit into from
Jan 28, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 28, 2020

Fixes #3588

Signed-off-by: David Gageot david@gageot.net

@dgageot
[bp] Use the same Docker client than Skaffold
b464a98 
Fixes GoogleContainerTools#3588

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jan 28, 2020 •
edited
Loading

Codecov Report

Merging #3602 into master will decrease coverage by 0.03%.
The diff coverage is 12.5%.

Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 75.67% <0%> (-0.69%) ⬇️
pkg/skaffold/build/buildpacks/lifecycle.go 75% <16.66%> (-6.09%) ⬇️

@tejal29 tejal29 merged commit d6910bb into GoogleContainerTools:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@briandealwis briandealwis Awaiting requested review from briandealwis

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skaffold dev examples/buildpacks fails on minikube
3 participants
@dgageot @tejal29 @googlebot