Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jib to 1.8.0 #3583

Closed
wants to merge 1 commit into from

Conversation

kkowalski
Copy link

@kkowalski kkowalski commented Jan 26, 2020

Description

Upgrade Jib to 1.8.0

User facing changes

N/A

Before

N/A

After

N/A

Next PRs.

N/A

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Adds documentation as needed: user docs, YAML reference, CLI reference.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

- Upgrade Jib to 1.8.0

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #3583 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jan 26, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 26, 2020
loosebazooka
loosebazooka previously approved these changes Jan 26, 2020
@TadCordle
Copy link
Contributor

Has GCB upgraded gradle yet? #3260 (comment)

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkowalski - I'd rather wait for @chanseokoh to confirm that the GCB gradle image is upgraded as @TadCordle pointed out. Thanks @TadCordle!

@balopat balopat added pr/blocked kokoro:run runs the kokoro jobs on a PR labels Jan 27, 2020
@kkowalski
Copy link
Author

@balopat Sure, should we keep this pr open for now ?

@chanseokoh
Copy link
Member

The integration test is failing because GCB uses Gradle 4.6 while Jib requires 4.9. (And the next Jib release will require 5.1.)

            An exception occurred applying plugin request [id: 'com.google.cloud.tools.jib', version: '1.8.0']
            > Failed to apply plugin [id 'com.google.cloud.tools.jib']
               > Detected Gradle 4.6, but jib requires Gradle 4.9 or higher. You can upgrade by running 'gradle wrapper --gradle-version=4.9'.

@balopat
Copy link
Contributor

balopat commented Jan 27, 2020

@balopat Sure, should we keep this pr open for now ?

We can keep it open & blocked as an active place for the jib upgrade to check for updates.

@chanseokoh chanseokoh added kokoro:run runs the kokoro jobs on a PR pr/blocked and removed pr/blocked kokoro:run runs the kokoro jobs on a PR labels Feb 11, 2020
@chanseokoh
Copy link
Member

GCB is purging the old Gradle 4.6 cache. @kkowalski could you update Jib version to 2.0.0?

@dgageot
Copy link
Contributor

dgageot commented Feb 20, 2020

Closing in favour of #3707

@dgageot dgageot closed this Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants