Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate inferred sync #3495

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 10, 2020

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #3495 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@briandealwis
Copy link
Member

I think this is obsoleted with the auto-inferred sync in #3496

@dgageot
Copy link
Contributor Author

dgageot commented Jan 14, 2020

@briandealwis I think #3496 might not be good.

@dgageot dgageot merged commit 22331a3 into GoogleContainerTools:master Jan 14, 2020
kelsk pushed a commit to kelsk/skaffold that referenced this pull request Apr 16, 2021
Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants