Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.13 #3412

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Upgrade to Go 1.13 #3412

merged 1 commit into from
Dec 20, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 20, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 20, 2019 •
edited
Loading

Codecov Report

Merging #3412 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/util/tar.go 57.47% <0%> (+4.59%) ⬆️
pkg/skaffold/build/tag/git_commit.go 83.11% <0%> (+13.99%) ⬆️

balopat
balopat approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thank you! I just tested it locally!

@dgageot dgageot merged commit 31589dc into GoogleContainerTools:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes pr/lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot