Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] update apiVersion of Deployment #3161

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[example] update apiVersion of Deployment #3161

merged 1 commit into from
Nov 6, 2019

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Nov 4, 2019

Relates to in case of new feature, this should point to issue/(s) which describes the feature

Fixes #3160. in case of a bug fix, this should point to a bug and any other related issue(s)

Should merge before : list any PRs that depend on this PR

Should merge after : list any PRs that are prerequisites to this PR

Description

User facing changes

n/a

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Update examples apiVersion of Deployment, Ingress

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #3161 into master will not change coverage.
The diff coverage is n/a.

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Nov 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 4, 2019
@oke-py oke-py changed the title [example] update apiVersion of Deployment, Ingress [example] update apiVersion of Deployment Nov 5, 2019
examples/kustomize/skaffold-kustomize-args.yaml Outdated Show resolved Hide resolved
examples/profile-patches/skaffold.yaml Outdated Show resolved Hide resolved
@dgageot
Copy link
Contributor

dgageot commented Nov 6, 2019

Please rebase your PR and them it's all good!

@oke-py oke-py requested a review from dgageot November 6, 2019 09:31
@oke-py
Copy link
Contributor Author

oke-py commented Nov 6, 2019

I rebased and force-pushed

@dgageot
Copy link
Contributor

dgageot commented Nov 6, 2019

@oke-py you rock!

@oke-py oke-py requested a review from dgageot November 6, 2019 12:48
@oke-py
Copy link
Contributor Author

oke-py commented Nov 6, 2019

Travis CI failed because of master branch. I rebased again to take in the patch for master.
Need kokoro:run?

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Nov 6, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Nov 6, 2019
@dgageot dgageot merged commit a49e0bd into GoogleContainerTools:master Nov 6, 2019
@oke-py oke-py deleted the apps/v1 branch November 7, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 examples are incompatible with k8s v1.16.
5 participants