[docs] add init docs #3149
Merged
[docs] add init docs #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
added
the
docs-modifications
|
Please visit http://35.235.117.222:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
Codecov Report
|
balopat
suggested changes
Nov 1, 2019
There was a problem hiding this comment.
There are two things mixed here:
a.) skaffold init functionality spec
b.) getting started workflow
In my mind tutorials rely on essential features and refer to them, not introduce them. So this is not a tutorial. I think a.) should be it's own doc probably under "Skaffold Pipeline Stages" - at one point init might become an automated piece as well!!! b.) should be under "Working with Skaffold" (after "Common Workflows" is renamed)
docs/content/en/docs/tutorials/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/tutorials/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
tejal29
force-pushed
the
add_init_docs
branch
from
ce33898 to
68e5b48
Compare
tejal29
added
the
docs-modifications
|
Please visit http://34.94.43.151:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
balopat
reviewed
Nov 4, 2019
balopat
suggested changes
Nov 4, 2019
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/workflows/getting-started-with-your-project.md
Outdated
Show resolved
Hide resolved
balopat
suggested changes
Nov 4, 2019
balopat
added
the
priority/p0
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
…nto add_init_docs
tejal29
requested review from
briandealwis,
chanseokoh and
loosebazooka
as code owners
balopat
added
the
docs-modifications
|
Error creating deployment, please see controller logs for details. |
container-tools-bot
removed
the
docs-modifications
|
Please visit http://34.94.185.45:1313 to view changes to the docs. |
|
Error creating deployment, please see controller logs for details. |
tejal29
added
the
docs-modifications
|
Please visit http://34.94.43.151:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
added
the
docs-modifications
|
Please visit http://34.94.115.173:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
balopat
approved these changes
Nov 5, 2019
|
|
||
| You can try it this out on example [jib project](https://github.com/GoogleContainerTools/skaffold/tree/master/examples/jib-multimodule) | ||
| ```bash | ||
| $cd examples/jib-multimodule |
There was a problem hiding this comment.
screenshot instead of code block
|
|
||
| For more understanding on how init works, see [`skaffold init`]({{<relref "/docs/pipeline-stages/init" >}}) | ||
|
|
||
| Try out [dev]({{<relref "/docs/workflows/dev" >}}), [debug]({{<relref "/docs/workflows/debug" >}}) workflows. |
There was a problem hiding this comment.
Suggested change
| Try out [dev]({{<relref "/docs/workflows/dev" >}}), [debug]({{<relref "/docs/workflows/debug" >}}) workflows. | |
| Try out [developing with Skaffold with hot reload]({{<relref "/docs/workflows/dev" >}}), or [debugging your apps with Skaffold on cluster]({{<relref "/docs/workflows/debug" >}}). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2951
Should merge before : list any PRs that depend on this PR
Should merge after : list any PRs that are prerequisites to this PR
Description
User facing changes
yes,
Next PRs.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes