-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init --analyze should return unique image names #3141
init --analyze should return unique image names #3141
Conversation
Fixes GoogleContainerTools#3128 Signed-off-by: Pradip Caulagi <caulagi@gmail.com>
Signed-off-by: Pradip Caulagi <caulagi@gmail.com>
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this @caulagi!
I think we can simplify this - if you add the test in TestResolveBuilderImages
and implement the "set semantics" for unresolvedImages via map[string]interface{}
in autoSelectBuilders
instead of the json printer methods. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
Signed-off-by: Pradip Caulagi <caulagi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please run a gofmt to fix the Travis Check
Oops, fixed. |
Fixes #3128
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes