[kaniko] Stop printing the logs on ctrl-c #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also ensures that the kaniko pod is deleted without waiting for the pod to terminate. Fixes GoogleContainerTools#3048 Signed-off-by: David Gageot <david@gageot.net>
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
Codecov Report
|
|
@dgageot thanks for fixing it I was about to ask whether its was bug or feature. |
|
@dgageot to cancel skaffold build I need to press Cntl+C twice, it doesn't kill the process when Cntl+C is pressed once . Is this intentionally done? |
|
@prary with this PR, as soon as you press Ctrl+C (once), it should stop streaming the logs and kill the pod. Before the PR, you'd have to press Ctr+c and wait until the build is finished. Or you could press two times but then it kills skaffold without giving it time to clean things up. |
balopat
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also ensures that the kaniko pod is deleted without waiting for the pod to terminate.
Fixes #3048
Signed-off-by: David Gageot david@gageot.net