Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check flake by not using Github API #3033

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Fix check flake by not using Github API #3033

merged 2 commits into from
Oct 10, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Oct 10, 2019

Fixes #3025.

@balopat balopat changed the title not using github API for the checks to avoid rate limit Fix check flake by not using Github API Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 10, 2019 •
edited
Loading

Codecov Report

Merging #3033 into master will decrease coverage by 0.01%.
The diff coverage is 21.42%.

Impacted Files Coverage Δ
pkg/skaffold/update/update.go 35.48% <21.42%> (+0.86%) ⬆️

@balopat balopat merged commit 565da32 into GoogleContainerTools:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake: 403 API rate limit exceeded
3 participants
@balopat @priyawadhwa @googlebot