Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display survey prompt which points to survey url #3011

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Oct 7, 2019

Relates to #3010

Description

User facing changes

yes
Before
no prompt displayed.

After
When hooked up the following prompt should get displayed

Help improve Skaffold! Take a 10 seconds anonymous survey.
    $ skaffold survey

Next PRs.

  • Add a skaffold config survey/disable_prompts to display prompts
  • Add implementation for skaffold survey command which opens the "https://forms.gle/BMTbGQXLWSdn7vEs6"
  • Add logic show once in 2 weeks untill user ran skaffold survey command.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • [ n/a] Adds documentation as needed: user docs, YAML reference, CLI reference.
  • [ n/a] Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #3011 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/survey/survey.go 100% <100%> (ø)
pkg/skaffold/docker/auth.go 55.76% <0%> (-7.03%) ⬇️
pkg/skaffold/build/custom/custom.go 62.5% <0%> (-1.44%) ⬇️
pkg/skaffold/runner/build_deploy.go 66.19% <0%> (-0.95%) ⬇️
pkg/skaffold/runner/diagnose.go 12.85% <0%> (-0.58%) ⬇️
pkg/skaffold/kubernetes/context/context.go 100% <0%> (ø) ⬆️
pkg/skaffold/build/misc/graceful.go 66.66% <0%> (ø)
pkg/skaffold/kubernetes/status_check.go 76.19% <0%> (ø)
pkg/skaffold/schema/profiles.go 88.57% <0%> (+0.13%) ⬆️
... and 7 more

Co-Authored-By: Balint Pato <balopat@users.noreply.github.com>
@tejal29 tejal29 merged commit 6bd7657 into GoogleContainerTools:master Oct 16, 2019
@tejal29 tejal29 deleted the add_survey_logic branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants