Every type of artifact should be handled. #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
tejal29
as code owners
dgageot
force-pushed
the
diagnose-every-type
branch
from
fa8ec08 to
6fd176e
Compare
Codecov Report
|
dgageot
force-pushed
the
diagnose-every-type
branch
2 times, most recently
from
e264bb7 to
9e945d2
Compare
If that’s not the case, we want to see it fail during tests. Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
diagnose-every-type
branch
from
9e945d2 to
4408a80
Compare
Signed-off-by: David Gageot <david@gageot.net>
tejal29
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If that’s not the case, we want to see it fail during tests.
Signed-off-by: David Gageot david@gageot.net
Reviewer Notes