Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly tag images with digest when using helm #2956

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Properly tag images with digest when using helm #2956

merged 1 commit into from
Oct 4, 2019

Conversation

michaelbeaumont
Copy link
Contributor

Fixes #2624 again as reintroduced by #2624

Description

User facing changes

Include digest in image tag when deploying with helm

Before

Skaffold did not output the digest, leading to outdated deployments

After

Ensure that the correct digest of an image is used.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #2956 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 77.25% <100%> (+0.41%) ⬆️

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Sep 27, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 27, 2019
@tejal29
Copy link
Contributor

tejal29 commented Oct 2, 2019

/cc @dgageot

@dgageot dgageot merged commit d5cfaa8 into GoogleContainerTools:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants