Show the duration of the deploy phase #2739

dgageot · 2019-08-28T12:40:07Z

Signed-off-by: David Gageot david@gageot.net

Fix GoogleContainerTools#2738 Signed-off-by: David Gageot <david@gageot.net>

codecov · 2019-08-28T15:17:46Z

Codecov Report

❗ No coverage uploaded for pull request base (master@dc6d62e). Click here to learn what that means.
The diff coverage is 100%.

Impacted Files	Coverage Δ
pkg/skaffold/runner/timings.go	`92.15% <100%> (ø)`

nkubala

not sure why the coverage isn't showing up, but I would bet our coverage is definitely increasing with this PR :)

dgageot requested review from balopat, nkubala, priyawadhwa and tejal29 as code owners August 28, 2019 12:40

googlebot added the cla: yes label Aug 28, 2019

dgageot mentioned this pull request Aug 28, 2019

skaffold dev output is polluted with redundant information #2740

Closed

dgageot force-pushed the fix-2738 branch from 2976b50 to a81fee9 Compare August 28, 2019 13:22

Show the duration of the deploy phase

4866dfc

Fix GoogleContainerTools#2738 Signed-off-by: David Gageot <david@gageot.net>

dgageot force-pushed the fix-2738 branch from a81fee9 to 4866dfc Compare August 28, 2019 15:07

nkubala approved these changes Aug 28, 2019

View reviewed changes

nkubala merged commit 4b79029 into GoogleContainerTools:master Aug 28, 2019