Use active gcloud credentials for executing cloudbuild when available #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
tejal29
as code owners
nkubala
force-pushed
the
gcb-creds
branch
2 times, most recently
from
ddd8051 to
392ed26
Compare
balopat
reviewed
Aug 28, 2019
| logrus.Infof("unable to retrieve google creds: %s", err.Error()) | ||
| logrus.Infof("falling back to application default credentials") | ||
| } | ||
| _, err = c.TokenSource.Token() |
There was a problem hiding this comment.
this line might panic - if CredentialsFromJSON results in error?
There was a problem hiding this comment.
good catch, added a return here
balopat
reviewed
Aug 28, 2019
| @@ -349,6 +349,7 @@ golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8T | |||
| google.golang.org/api v0.4.0/go.mod h1:8k5glujaEP+g9n7WNsDg8QP6cUVNI86fCNMcbazEtwE= | |||
| google.golang.org/api v0.7.0 h1:9sdfJOzWlkqPltHAuzT2Cp+yrBeY1KRVYgms8soxMwM= | |||
| google.golang.org/api v0.7.0/go.mod h1:WtwebWUNSVBH/HAw79HIFXZNqEvBhG+Ra+ax0hx3E3M= | |||
| google.golang.org/api v0.9.0 h1:jbyannxz0XFD3zdjgrSUsaJbgpH4eTrkdhRChkHPfO8= | |||
There was a problem hiding this comment.
why did we need this update?
Codecov Report
|
balopat
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that skaffold always tries to use a user's active gcloud credentials when making calls through the Cloud Build and Cloud Storage client libraries, instead of requiring that the user has Application Default Credentials created on their host machine. Unfortunately the only way these credentials can be accessed is through shelling out to gcloud, so that's what we do here.
Fixes #1966