Fix issue with remote Kustomizations in dev mode. (#2581) #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls#2581) Remote Kustomization support was added previously, but it only supported remote resources referenced inside of a Kustomization config file rather than remote Kustomization config files themselves. This commit causes the file watcher code to assume the absence of a Kustomization config means that it is a remote reference and skips it since it can't watch remote files for changes. It pushes error handling onto Kustomize itself for invalid remote locations.
jmcclell
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tejal29
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2581
Remote Kustomization support was added previously, but it only supported
remote resources referenced inside of a Kustomization config file rather
than remote Kustomization config files themselves. This commit causes
the file watcher code to assume the absence of a Kustomization config
means that it is a remote reference and skips it since it can't watch
remote files for changes. It pushes error handling onto Kustomize
itself for invalid remote locations.