Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to kubectl and kustomize deployers #2537

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Minor changes to kubectl and kustomize deployers #2537

merged 3 commits into from
Jul 29, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 24, 2019

  • Make both deployers look more the same
  • Add missing deploy failure event
  • Remove some duplication

@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited
Loading

Codecov Report

Merging #2537 into master will increase coverage by 0.04%.
The diff coverage is 72.22%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/transformations.go 0% <0%> (ø)
pkg/skaffold/util/util.go 86.66% <100%> (+5.18%) ⬆️
pkg/skaffold/deploy/kubectl.go 72.5% <75%> (+0.54%) ⬆️
pkg/skaffold/deploy/kustomize.go 76.14% <77.77%> (-1.93%) ⬇️

dgageot added 3 commits July 28, 2019 19:38
@dgageot
Remove duplication
10a6593 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Make kubectl and kustomise deployers look more the same
49a2004 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Add missing deploy failure
6c5d0c4 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot merged commit 7287f41 into GoogleContainerTools:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @priyawadhwa @googlebot