Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the logs when there's no skaffold.yaml #2467

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 15, 2019

Before:

$ skaffold build
WARN[0000] Your Skaffold version might be too old. Download the latest version (0.33.0) at https://storage.googleapis.com/skaffold/releases/latest/skaffold-darwin-amd64
Complete in 394.890149ms
FATA[0000] creating runner: parsing skaffold config: read skaffold config: open skaffold.yaml: no such file or directory

After:

$ skaffold build
FATA[0000] creating runner: [skaffold.yaml] not found. You might need to run `skaffold init`

dgageot added 2 commits July 15, 2019 10:54
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #2467 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/build.go 88.46% <ø> (-1.54%) ⬇️
cmd/skaffold/app/cmd/runner.go 69.23% <100%> (+0.8%) ⬆️

@tejal29 tejal29 merged commit 883d134 into GoogleContainerTools:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants