Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --reproducible for Kaniko build #2453

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Support --reproducible for Kaniko build #2453

merged 1 commit into from
Jul 12, 2019

Conversation

tbarrella
Copy link
Contributor

To close #2168

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #2453 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/kaniko.go 44.28% <100%> (+1.63%) ⬆️

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Jul 12, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 12, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for submitting this!

@balopat balopat merged commit fa1e705 into GoogleContainerTools:master Jul 12, 2019
@tbarrella tbarrella deleted the reproducible branch July 14, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for use of named kaniko flags unclear
4 participants