Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script that creates a new version to make it work on osx #2429

Merged
merged 2 commits into from
Jul 8, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 8, 2019

No description provided.

dgageot added 2 commits July 8, 2019 13:24
Signed-off-by: David Gageot <david@gageot.net>
Fix GoogleContainerTools#1919

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #2429 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/schema/util/util.go 81.81% <ø> (ø) ⬆️

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by eyeballing, I'll run a comparison side-by-side soon.

@balopat balopat merged commit 486e4b0 into GoogleContainerTools:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants