Wait for parallel builds to be cancelled on error #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if building the first cluster artifact failed, skaffold would exit immediately after. Build goroutines for other artifacts may have still been running and not get a chance to clean up The Kaniko build has logic to handle cancellation, but allow custom commands to be cancelled as well
tbarrella
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tbarrella
commented
Jul 6, 2019
Codecov Report
|
dgageot
suggested changes
Jul 8, 2019
dgageot
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #2268
Previously, if building the first cluster artifact failed, skaffold
would exit immediately after. Build goroutines for other artifacts may
have still been running and not get a chance to clean up
The Kaniko build has logic to handle cancellation, but allow custom
commands to be cancelled as well
I'm still new to Go so be liberal with requesting changes