Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #2343

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Update examples #2343

merged 2 commits into from
Jun 26, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 26, 2019 •
edited
Loading

  • Some examples use an outdated version
  • The helm example had two skaffold.yaml files

@dgageot
Update examples to latest version
3c94e2a 
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #2343 into master will not change coverage.
The diff coverage is n/a.

@dgageot
Copy a helm sample to testdata for integration tests
ad823ee 
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat merged commit f34a7db into GoogleContainerTools:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @balopat @googlebot