Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the logs #2323

Merged
merged 8 commits into from
Jun 28, 2019
Merged

Improve the logs #2323

merged 8 commits into from
Jun 28, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 23, 2019

  • Don’t leak go routines
  • Never reprint the log for a given container
  • Simplify code
  • Handle init containers first
  • Notify that container logs ended

@dgageot
Copy link
Contributor Author

dgageot commented Jun 23, 2019

@balopat I simplified my PR because it was buggy. I decided to stop printing the container's final state because it's too unreliable. Printing when container logs end is, if think, good enough.

@codecov
Copy link

codecov bot commented Jun 23, 2019 •
edited
Loading

Codecov Report

Merging #2323 into master will increase coverage by 0.13%.
The diff coverage is 11.11%.

Impacted Files Coverage Δ
pkg/skaffold/runner/build_deploy.go 51.35% <0%> (-1.43%) ⬇️
pkg/skaffold/kubernetes/log.go 31.25% <10.34%> (+5.64%) ⬆️
pkg/skaffold/runner/dev.go 63.88% <25%> (+0.5%) ⬆️

@dgageot dgageot force-pushed the final-logs-2 branch 6 times, most recently from 81e55cc to dc122a3 Compare June 27, 2019 22:04
dgageot added 8 commits June 28, 2019 17:09
@dgageot
Don’t leak go routines
dbebb59 
Make sure streamRequest() exits.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Never reprint the log for a given container
f6679c9 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Simplify code
b30552e 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Handle init containers first
7577a46 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Handle every type of events
b7f0772 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Notify the user that the container logs ended
a59f050 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Also match init containers when selecting pods
580078b 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Don’t print logs while deploy is running.
f181475 
But once deploy is done, print the logs up the
just before deploy was started.

Signed-off-by: David Gageot <david@gageot.net>
@tejal29 tejal29 merged commit 734e5e3 into GoogleContainerTools:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @tejal29 @googlebot