Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go bazel rules to in examples to fix bazel breaking release 0.18.6 #2311

Merged
merged 3 commits into from
Jun 25, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Jun 21, 2019

One of the integration tests failed with following error:

The issue is : bazelbuild/bazel#7793
Upgrading example should fix this.

ERROR: /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_go/BUILD.bazel:65:1: in go_context_data rule @io_bazel_rules_go//:go_context_data:
            Traceback (most recent call last):
            	File "/root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_go/BUILD.bazel", line 65
            		go_context_data(name = 'go_context_data')
            	File "/root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_go/go/private/context.bzl", line 396, in _go_context_data_impl
            		cc_common.configure_features(cc_toolchain = cc_toolchain, reque..., ...)
            Incompatible flag --incompatible_require_ctx_in_configure_features has been flipped, and the mandatory parameter 'ctx' of cc_common.configure_features is missing. Please add 'ctx' as a named parameter. See https://github.com/bazelbuild/bazel/issues/7793 for details.
            DEBUG: Rule 'org_golang_x_tools' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "2384fa91351a7414b643c5230422ce45f5aa2be8a82727609afd4e64e6973a30"
            DEBUG: Call stack for the definition of repository 'org_golang_x_tools' which is a http_archive (rule definition at /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/bazel_tools/tools/build_defs/repo/http.bzl:237:16):
             - /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_go/go/private/repositories.bzl:199:9
             - /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_go/go/private/repositories.bzl:32:5
             - /go/src/github.com/GoogleContainerTools/skaffold/integration/examples/bazel/WORKSPACE:20:1
            INFO: Call stack for the definition of repository 'six' which is a http_archive (rule definition at /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/bazel_tools/tools/build_defs/repo/http.bzl:237:16):
             - /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_docker/repositories/repositories.bzl:109:9
             - /root/.cache/bazel/_bazel_root/763bd7ff73f8885b0a98ed87a918afef/external/io_bazel_rules_docker/go/image.bzl:43:5
             - /go/src/github.com/GoogleContainerTools/skaffold/integration/examples/bazel/WORKSPACE:30:1
            ERROR: Analysis of target '//:skaffold_example.tar' failed; build aborted: Analysis of target '@io_bazel_rules_go//:go_context_data' failed; build aborted
            INFO: Elapsed time: 34.360s

@tejal29 tejal29 changed the title upgrade go bazel rules to in examples bazel breaking release 0.18.6 upgrade go bazel rules to in examples to fix bazel breaking release 0.18.6 Jun 21, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #2311 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 78.49% <0%> (+1.07%) ⬆️

sha256 = "aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d",
strip_prefix = "rules_docker-0.8.0",
urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.8.0.tar.gz"],
sha256 = "5647f4f7a6b7c247e788675963e2e03a6e7156e1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sha256 seems wrong.

ERROR: An error occurred during the fetch of repository 'io_bazel_rules_docker': com.google.devtools.build.lib.syntax.EvalException: Definition of repository io_bazel_rules_docker: Syntactically invalid SHA256 checksum: '5647f4f7a6b7c247e788675963e2e03a6e7156e1' at /go/src/github.com/GoogleContainerTools/skaffold/integration/examples/bazel/WORKSPACE:6:1

It should be 3556d4972571f288f8c43378295d84ed64fef5b1a875211ee1046f9f6b4258fa: https://github.com/bazelbuild/rules_docker#setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! updated it!

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@priyawadhwa priyawadhwa merged commit 85a67b7 into GoogleContainerTools:master Jun 25, 2019
@tejal29 tejal29 deleted the fix_example branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants