-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade go bazel rules to in examples to fix bazel breaking release 0.18.6 #2311
Conversation
Codecov Report
|
integration/examples/bazel/WORKSPACE
Outdated
sha256 = "aed1c249d4ec8f703edddf35cbe9dfaca0b5f5ea6e4cd9e83e99f3b0d1136c3d", | ||
strip_prefix = "rules_docker-0.8.0", | ||
urls = ["https://github.com/bazelbuild/rules_docker/archive/v0.8.0.tar.gz"], | ||
sha256 = "5647f4f7a6b7c247e788675963e2e03a6e7156e1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sha256 seems wrong.
ERROR: An error occurred during the fetch of repository 'io_bazel_rules_docker': com.google.devtools.build.lib.syntax.EvalException: Definition of repository io_bazel_rules_docker: Syntactically invalid SHA256 checksum: '5647f4f7a6b7c247e788675963e2e03a6e7156e1' at /go/src/github.com/GoogleContainerTools/skaffold/integration/examples/bazel/WORKSPACE:6:1
It should be 3556d4972571f288f8c43378295d84ed64fef5b1a875211ee1046f9f6b4258fa
: https://github.com/bazelbuild/rules_docker#setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! updated it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One of the integration tests failed with following error:
The issue is : bazelbuild/bazel#7793
Upgrading example should fix this.