Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check man page with a unit test instead of a script #2180

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 27, 2019

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #2180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2180   +/-   ##
=======================================
  Coverage   58.55%   58.55%           
=======================================
  Files         188      188           
  Lines        7882     7882           
=======================================
  Hits         4615     4615           
  Misses       2877     2877           
  Partials      390      390

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b139240...c4d9702. Read the comment docs.

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea here that contributors are more likely to see this error before they submit rather than during the CI build? Or are you looking to move the testing steps from make test into the normal testing flow?

@dgageot
Copy link
Contributor Author

dgageot commented May 27, 2019

It should be the same for contributors. Yes, the idea is to move the testing steps from make test into the normal testing flow.

@dgageot
Copy link
Contributor Author

dgageot commented May 30, 2019

@balopat Could you TAL at this one. It's very minor

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the check-man-unit-test branch from 22a26b0 to c4d9702 Compare June 1, 2019 11:23
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@balopat balopat merged commit a9b781b into GoogleContainerTools:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants