Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test for skaffold diagnose #2157

Merged

Conversation

corneliusweig
Copy link
Contributor

The skaffold diagnose command has bad test coverage (both integration and unit tests). There are reasons why it may not make sense to have full unit test coverage there. However, basic test coverage should be there to check whether the subcommand runs at all.

This PR adds basic smoke tests which check if skaffold diagnose runs successfully. It covers all artifact types that have an example.

Try to cover all artifact types

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@codecov-io
Copy link

Codecov Report

Merging #2157 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2157     +/-   ##
=========================================
+ Coverage   56.74%   56.95%   +0.2%     
=========================================
  Files         183      183             
  Lines        7860     7961    +101     
=========================================
+ Hits         4460     4534     +74     
- Misses       2988     3012     +24     
- Partials      412      415      +3
Impacted Files Coverage Δ
pkg/skaffold/build/cluster/sources/sources.go 87.87% <0%> (-1.46%) ⬇️
pkg/skaffold/build/cluster/kaniko.go 36.27% <0%> (-0.87%) ⬇️
pkg/skaffold/schema/v1beta10/upgrade.go 73.33% <0%> (+6.66%) ⬆️
pkg/skaffold/build/tag/git_commit.go 86.9% <0%> (+6.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9916f...e01fb80. Read the comment docs.

@balopat
Copy link
Contributor

balopat commented May 20, 2019

Nice!!! Thank you for this!

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label May 21, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 21, 2019
@dgageot dgageot merged commit 6f6447a into GoogleContainerTools:master May 21, 2019
@corneliusweig corneliusweig deleted the diagnose-integration branch May 22, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants