Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile to custom dependencies #2049

Merged
merged 2 commits into from
May 8, 2019

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented May 1, 2019

Allows users to say something like:

- image: my image
  custom:
     buildCommand: ./build.sh
     dependencies:
        dockerfile:
           path: path/to/Dockerfile
           buildArgs:
             - file:foo
           target: secondStage

@codecov-io
Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #2049 into master will increase coverage by 0.24%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2049      +/-   ##
==========================================
+ Coverage   55.93%   56.17%   +0.24%     
==========================================
  Files         178      180       +2     
  Lines        7689     7768      +79     
==========================================
+ Hits         4301     4364      +63     
- Misses       2973     2987      +14     
- Partials      415      417       +2
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/local/local.go 37.31% <0%> (ø) ⬆️
pkg/skaffold/schema/validation/validation.go 96.29% <80%> (-3.71%) ⬇️
pkg/skaffold/build/custom/dependencies.go 85.71% <85.71%> (+7.93%) ⬆️
cmd/skaffold/app/cmd/deploy.go 45.83% <0%> (-29.17%) ⬇️
pkg/skaffold/runner/runner.go 64.77% <0%> (-2.1%) ⬇️
cmd/skaffold/app/cmd/build.go 69.04% <0%> (ø) ⬆️
pkg/skaffold/build/util.go 100% <0%> (ø) ⬆️
pkg/skaffold/config/options.go 90.47% <0%> (ø) ⬆️
pkg/skaffold/build/prebuilt.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4d696...9d09ae4. Read the comment docs.

@priyawadhwa priyawadhwa requested a review from tejal29 May 7, 2019 19:45
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I am not aware if current config version is frozen. Please verify before you merge!.

@priyawadhwa
Copy link
Contributor Author

Yup, we've frozen v1beta9 from the last release and this is making changes to v1beta10.

@priyawadhwa priyawadhwa merged commit 63f353f into GoogleContainerTools:master May 8, 2019
@priyawadhwa priyawadhwa deleted the deps branch May 8, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants