Make Deploy flags more relevant #2018
Conversation
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
|
Let me know if |
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
+ Coverage 55.72% 55.77% +0.05%
==========================================
Files 173 173
Lines 7503 7512 +9
==========================================
+ Hits 4181 4190 +9
Misses 2931 2931
Partials 391 391
Continue to review full report at Codecov.
|
|
I think --tail still makes sense for |
| cmd.Flags().BoolVar(&opts.Force, "force", false, "Recreate kubernetes resources if necessary for deployment (default: false, warning: might cause downtime!)") | ||
| cmd.Flags().StringArrayVarP(&opts.CustomLabels, "label", "l", nil, "Add custom labels to deployed objects. Set multiple times for multiple labels.") | ||
| } | ||
|
|
||
| func AddRunDeployOnlyFlags(cmd *cobra.Command) { |
There was a problem hiding this comment.
I'm starting to get really lost in this naming scheme. What does it mean that RunDeployOnly and how does it differ from RunDeployCommon? I'm starting to think that we should just add commands=[]string{"run", "dev", "deploy"} annotation to the flags somehow...:)
There was a problem hiding this comment.
yes. its a good idea to add scope annotation to flags. Its kind of confusing right now. Especially when they call each other.
When rewriting
skaffold deployi realizedskaffold deployhas--tailoption which is not required.skaffold runuses--tailSome of the
skaffold deployflags are not relevant like--insecure-registries,--no-prune.Please let me know if this is incorrect.
Please see https://github.com/GoogleContainerTools/skaffold/compare/master...tejal29:make_sane_deploy_flags?expand=1#diff-2e110939e227b787655acb75b7eea64f to see the flag difference.
Flags removed: