Don't run GCB example on structure tests #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
requested review from
balopat,
dgageot,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1984 +/- ##
=======================================
Coverage 53.11% 53.11%
=======================================
Files 183 183
Lines 7953 7953
=======================================
Hits 4224 4224
Misses 3328 3328
Partials 401 401Continue to review full report at Codecov.
|
priyawadhwa
approved these changes
Apr 18, 2019
|
|
||
| This is a simple example based on | ||
|
|
||
| * *building* a single go file app and with a multistage `Dockerfile` using local docker to build |
There was a problem hiding this comment.
nit: using GCB to build
nkubala
force-pushed
the
structure-test-integration
branch
from
f3d7618 to
bb4d290
Compare
nkubala
force-pushed
the
structure-test-integration
branch
from
bb4d290 to
93c3d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running structure tests through GCB doesn't currently work (since the structure tests are run locally but the image was built directly to a registry), so let's just run this in a different directory until that problem is fixed.