Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo fmt.Fprint -> color.White.Fprint #1903

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

tjk
Copy link
Contributor

@tjk tjk commented Apr 1, 2019

I believe this would fix #1664 but not sure what it breaks about experimental GUI (dcfb2e3)?

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Apr 1, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 1, 2019
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it out with the experimental gui with light and dark backgrounds, seems to be fine. in general I think using white is probably not a great idea 😆

@codecov-io
Copy link

Codecov Report

Merging #1903 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1903   +/-   ##
=======================================
  Coverage   49.46%   49.46%           
=======================================
  Files         174      174           
  Lines        8036     8036           
=======================================
  Hits         3975     3975           
  Misses       3683     3683           
  Partials      378      378
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 21.31% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113cc47...e858f8a. Read the comment docs.

@balopat balopat merged commit 1127984 into GoogleContainerTools:master Apr 2, 2019
@tejal29 tejal29 mentioned this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold v0.23 log tail unreadable
7 participants