Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve manual installation instruction for windows #1883

Merged
merged 5 commits into from
Mar 27, 2019

Conversation

corneliusweig
Copy link
Contributor

Also

  • remove trailing whitespace in docs
  • add shebang in hack/release.sh
  • ensure generated doc has no trailing whitespace

Fixes #1762

@codecov-io
Copy link

Codecov Report

Merging #1883 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   50.15%   50.15%           
=======================================
  Files         168      168           
  Lines        7363     7363           
=======================================
  Hits         3693     3693           
  Misses       3312     3312           
  Partials      358      358
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/build.go 68.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eaf552...d239b6e. Read the comment docs.

@balopat balopat added docs-modifications runs the docs preview service on the given PR kokoro:run runs the kokoro jobs on a PR labels Mar 27, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Mar 27, 2019
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Mar 27, 2019
@container-tools-bot
Copy link

Please visit http://35.236.113.232:1313 to view changes to the docs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@balopat balopat merged commit da0ce3b into GoogleContainerTools:master Mar 27, 2019
@corneliusweig corneliusweig deleted the windows-doc branch March 27, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants