Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #1827

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 19, 2019

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1827 into master will increase coverage by 1.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
+ Coverage   45.42%   46.51%   +1.08%     
==========================================
  Files         143      143              
  Lines        6683     6677       -6     
==========================================
+ Hits         3036     3106      +70     
+ Misses       3341     3269      -72     
+ Partials      306      302       -4
Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 82.05% <100%> (+46.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c7f56...a7995db. Read the comment docs.

@dgageot dgageot merged commit 0e0cfae into GoogleContainerTools:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants