Adding a few tests for skaffold build
#1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
======================================
Coverage 46.9% 46.9%
======================================
Files 119 119
Lines 5134 5134
======================================
Hits 2408 2408
Misses 2478 2478
Partials 248 248Continue to review full report at Codecov.
|
dgageot
force-pushed
the
tests-skaffold-build
branch
3 times, most recently
from
397cc60 to
74496ec
Compare
See GoogleContainerTools#441 Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
tests-skaffold-build
branch
from
74496ec to
49fa1af
Compare
priyawadhwa
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #441
Signed-off-by: David Gageot david@gageot.net