-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental UI mode for skaffold dev
#1533
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1533 +/- ##
==========================================
- Coverage 46.88% 46.27% -0.62%
==========================================
Files 118 118
Lines 5042 5109 +67
==========================================
Hits 2364 2364
- Misses 2446 2512 +66
- Partials 232 233 +1
Continue to review full report at Codecov.
|
81b0239
to
940ff12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the visual separation a lot and it gives a foundation for a "dashboard" kind of view that we can implement iteratively on top of this direction. Has a lot of potential.
I really don't like that I can't scroll up - I'm losing history basically.
I think if we figure out scrolling we can merge this.
I would also like to see a "legend" describing "Ctrl + C can exit" or similar.
@balopat I'll try to see how this can be improved. I was thinking we could merge this code if an experimental flag can be used to activate this UI. wdyt? |
e8f792d
to
b4993ba
Compare
I'm okay having behind an experimental flag! |
@balopat should be good to review then |
ba6a88d
to
5a8bdcf
Compare
Only for `skaffold dev` Signed-off-by: David Gageot <david@gageot.net>
Only for `skaffold dev` Signed-off-by: David Gageot <david@gageot.net>
This feature is broken for me: skaffold dev --experimental-gui I'm also expected a proper GUI. But this is just a text-interface :p |
I really like it to be honest, good work! Having problems only with scrolling (history loss) as mentioned before. |
Please have a try and tell me what you think about it!