Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for non Docker artifacts built with Kaniko #1494

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 19, 2019

Fix #954

Signed-off-by: David Gageot david@gageot.net

@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #1494 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
- Coverage   44.87%   44.85%   -0.02%     
==========================================
  Files         115      115              
  Lines        4771     4773       +2     
==========================================
  Hits         2141     2141              
- Misses       2409     2411       +2     
  Partials      221      221
Impacted Files Coverage Δ
pkg/skaffold/build/kaniko/run.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bcca6...e64564a. Read the comment docs.

Fix GoogleContainerTools#954

Signed-off-by: David Gageot <david@gageot.net>
@nkubala nkubala merged commit aace573 into GoogleContainerTools:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants