[kubectl] apply labels by patching yaml

[dgageot]

This is a much simpler way of labelling resources when using kubectl.

Signed-off-by: David Gageot david@gageot.net

[nkubala]

I'm 85% sure there's a reason we didn't do it this way in the first place, but I can't remember. @r2d4 @dlorenc am I crazy

[codecov-io]

Codecov Report

Merging #1489 into master will increase coverage by 0.18%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   46.51%   46.69%   +0.18%     
==========================================
  Files         118      119       +1     
  Lines        5044     5060      +16     
==========================================
+ Hits         2346     2363      +17     
+ Misses       2464     2463       -1     
  Partials      234      234

Impacted Files	Coverage Δ
pkg/skaffold/deploy/labels.go	15.85% <ø> (+6.09%)	⬆️
pkg/skaffold/deploy/kubectl/cli.go	0% <0%> (ø)	⬆️
pkg/skaffold/deploy/kustomize.go	36% <0%> (+1.38%)	⬆️
pkg/skaffold/deploy/kubectl.go	75.86% <66.66%> (-1.75%)	⬇️
pkg/skaffold/deploy/kubectl/labels.go	78.57% <78.57%> (ø)
pkg/skaffold/deploy/util.go	68% <0%> (-8%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6437d83...dd8e017. Read the comment docs.

[dgageot]

@nkubala the problem is that now, there's two implementations. One for kubctl/kustomize, one for helm. Maybe you wanted to have a single implementation.

[nkubala]

@dgageot I don't think that was it, but I can't think of a good reason now so forget about it.

Kokoro is failing but it looks like it might have been a network issue, restarting the build

[nkubala]