Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bazel args to bazel info bazel-bin #1487

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 18, 2019

Fixes #1467

Signed-off-by: David Gageot david@gageot.net

Fixes GoogleContainerTools#1467

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

Codecov Report

Merging #1487 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
+ Coverage   44.82%   44.85%   +0.02%     
==========================================
  Files         115      115              
  Lines        4767     4769       +2     
==========================================
+ Hits         2137     2139       +2     
  Misses       2409     2409              
  Partials      221      221
Impacted Files Coverage Δ
pkg/skaffold/build/local/bazel.go 42.55% <80%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec7dc3...1195312. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1487 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
+ Coverage   44.82%   44.85%   +0.02%     
==========================================
  Files         115      115              
  Lines        4767     4769       +2     
==========================================
+ Hits         2137     2139       +2     
  Misses       2409     2409              
  Partials      221      221
Impacted Files Coverage Δ
pkg/skaffold/build/local/bazel.go 42.55% <80%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec7dc3...1195312. Read the comment docs.

@nkubala nkubala merged commit 51bcca6 into GoogleContainerTools:master Jan 19, 2019
@balopat balopat changed the title Pass bazel args to bazel info hazel-bin Pass bazel args to bazel info bazel-bin Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants